fix/ocp_api_context #524
Merged
fix/ocp_api_context #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass kwarg for source message, in some cases dig_for_message returns None (unsure when it happens, but issues noticed with hivemind) companion to OpenVoiceOS/ovos-bus-client#103
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #524 +/- ##
==========================================
+ Coverage 75.57% 75.67% +0.09%
==========================================
Files 15 15
Lines 3042 3042
==========================================
+ Hits 2299 2302 +3
+ Misses 743 740 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the OCP query messages were dropping message source and destination
missed OCPQuery class in previous PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass kwarg for source message, in some cases dig_for_message returns None
companion to OpenVoiceOS/ovos-bus-client#103
unsure when it happens, but issues noticed with hivemind
to test ask to play something from a voice sat, without this PR the destination might be missing and playback happens in core, not in voice sat. sometimes it works so i am not sure what causes dig_for_message to occasionally miss the source message